From c3f513e0220fca8e4685a9b993b9c826454c2abb Mon Sep 17 00:00:00 2001 From: Bouwe Westerdijk Date: Thu, 16 May 2024 12:34:01 +0200 Subject: [PATCH 1/6] Revert "Clean-up" This reverts commit 7238b2817e948daba03bebcbf621b986f269beab. --- plugwise/__init__.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/plugwise/__init__.py b/plugwise/__init__.py index d9e575cc8..3bc49a963 100644 --- a/plugwise/__init__.py +++ b/plugwise/__init__.py @@ -332,6 +332,10 @@ async def set_number( """Set the max. Boiler or DHW setpoint on the Central Heating boiler.""" await self._smile_api.set_number(dev_id, key, temperature) + async def set_temperature_offset(self, _: str, dev_id: str, offset: float) -> None: + """Set the Temperature offset for thermostats that support this feature.""" + await self._smile_api.set_temperature_offset(dev_id, offset) + async def set_switch_state( self, appl_id: str, members: list[str] | None, model: str, state: str ) -> None: From aa571850eb5c666de5ab5a1fe1786b8d3337a0e1 Mon Sep 17 00:00:00 2001 From: Bouwe Westerdijk Date: Thu, 16 May 2024 12:40:20 +0200 Subject: [PATCH 2/6] Improvements --- plugwise/__init__.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugwise/__init__.py b/plugwise/__init__.py index 3bc49a963..18b666728 100644 --- a/plugwise/__init__.py +++ b/plugwise/__init__.py @@ -329,12 +329,12 @@ async def set_number( key: str, temperature: float, ) -> None: - """Set the max. Boiler or DHW setpoint on the Central Heating boiler.""" + """Set the maximum boiler- or DHW-setpoint on the Central Heating boiler or the temperature-offset on a Thermostat.""" await self._smile_api.set_number(dev_id, key, temperature) - async def set_temperature_offset(self, _: str, dev_id: str, offset: float) -> None: + async def set_temperature_offset(self, dev_id: str, offset: float) -> None: """Set the Temperature offset for thermostats that support this feature.""" - await self._smile_api.set_temperature_offset(dev_id, offset) + await self._smile_api.set_offset(dev_id, offset) async def set_switch_state( self, appl_id: str, members: list[str] | None, model: str, state: str From 7710d6133bb82aa532579d3b4600752aa2e44a85 Mon Sep 17 00:00:00 2001 From: Bouwe Westerdijk Date: Thu, 16 May 2024 12:48:52 +0200 Subject: [PATCH 3/6] Add pragma: no cover --- plugwise/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugwise/__init__.py b/plugwise/__init__.py index 18b666728..9ccbf8335 100644 --- a/plugwise/__init__.py +++ b/plugwise/__init__.py @@ -334,7 +334,7 @@ async def set_number( async def set_temperature_offset(self, dev_id: str, offset: float) -> None: """Set the Temperature offset for thermostats that support this feature.""" - await self._smile_api.set_offset(dev_id, offset) + await self._smile_api.set_offset(dev_id, offset) # pragma: no cover async def set_switch_state( self, appl_id: str, members: list[str] | None, model: str, state: str From 4f7ef8f097b0b425f66f89673e46b68e6e131fca Mon Sep 17 00:00:00 2001 From: Bouwe Westerdijk Date: Thu, 16 May 2024 12:54:28 +0200 Subject: [PATCH 4/6] Fix mypy error --- plugwise/legacy/smile.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugwise/legacy/smile.py b/plugwise/legacy/smile.py index 24761a9da..3749d78f9 100644 --- a/plugwise/legacy/smile.py +++ b/plugwise/legacy/smile.py @@ -273,3 +273,6 @@ async def set_temperature(self, _: str, items: dict[str, float]) -> None: ) await self._request(uri, method="put", data=data) + + async def set_temperature_offset(self, dev_id: str, offset: float) -> None: + """Set-function placeholder for legacy devices.""" From c1cc3ccc62f13d3ce392684e8fc13b6b58676743 Mon Sep 17 00:00:00 2001 From: Bouwe Westerdijk Date: Thu, 16 May 2024 13:00:27 +0200 Subject: [PATCH 5/6] Correct --- plugwise/legacy/smile.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugwise/legacy/smile.py b/plugwise/legacy/smile.py index 3749d78f9..7658c6e16 100644 --- a/plugwise/legacy/smile.py +++ b/plugwise/legacy/smile.py @@ -162,6 +162,9 @@ async def set_number( ) -> None: """Set-function placeholder for legacy devices.""" + async def set_offset(self, dev_id: str, offset: float) -> None: + """Set-function placeholder for legacy devices.""" + async def set_preset(self, _: str, preset: str) -> None: """Set the given Preset on the relevant Thermostat - from DOMAIN_OBJECTS.""" if (presets := self._presets()) is None: @@ -273,6 +276,3 @@ async def set_temperature(self, _: str, items: dict[str, float]) -> None: ) await self._request(uri, method="put", data=data) - - async def set_temperature_offset(self, dev_id: str, offset: float) -> None: - """Set-function placeholder for legacy devices.""" From 23d91c41fcf86eb84fe55b3cc3177c463d46b096 Mon Sep 17 00:00:00 2001 From: Bouwe Westerdijk Date: Thu, 16 May 2024 13:52:10 +0200 Subject: [PATCH 6/6] Update CHANGELOG --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 473a4c35a..df518d7bf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Changelog +## Ongoing + +- Revert removal of set_temperature_offset() function. + ## v0.37.5 - Add setting the thermostat temperature_offset to the set_number() function.