Allow nil #15

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants
Contributor

aiba commented Mar 2, 2013

This change will ignore nil elements in templates instead of throwing an error. This is useful if you want to put (when) clauses directly in a template, and matches the behavior of hiccup.core/html.

Contributor

mpenet commented Mar 13, 2013

+1

I need this as well.

Is this still an issue?

Contributor

mpenet commented Mar 21, 2013

My guess is yes, since it hasn't been merged. I don't think the previous PR fixes that but I didn't test it.

It's still broken.

Uncaught Don't know how to make node from: nil

On Mar 21, 2013, at 4:10 PM, Max Penet notifications@github.com wrote:

My guess is yes, since it hasn't been merged. I don't think the previous PR fixes that but I didn't test it.


Reply to this email directly or view it on GitHub.

Contributor

aria42 commented Mar 21, 2013

Sorry we're really slammed right now, we do have this fixed internally and will release a fix along with some other new features soon.

Cool. I'm just starting my first ClojureScript project, and currently figuring out all the libraries I'll need :)

Contributor

mpenet commented Mar 22, 2013

I put a patched version on clojars in case you need it now (I do). https://clojars.org/cc.qbits/dommy (matches this branch https://github.com/mpenet/dommy/tree/patched )

Contributor

mpenet commented Mar 22, 2013

By the way that made me notice: the versioning # are a bit odd, I don't know if you follow semver, but 0.0.3 should be 0.3.0 instead probably.

Thanks, Max.

I know you guys are busy, but this was opened a month ago. Seems like this should have been merged by now.

Contributor

aria42 commented Apr 1, 2013

We're just about to push an update (1-2 days) that fixes this guy and does many more things

Sent from my iPhone

On Apr 1, 2013, at 8:01 AM, David Sargeant notifications@github.com wrote:

I know you guys are busy, but this was opened a month ago. Seems like this should have been merged by now.


Reply to this email directly or view it on GitHub.

Awesome. Looking forward to it!

On Apr 1, 2013, at 11:47 AM, Aria Haghighi notifications@github.com wrote:

We're just about to push an update (1-2 days) that fixes this guy and does many more things

Sent from my iPhone

On Apr 1, 2013, at 8:01 AM, David Sargeant notifications@github.com wrote:

I know you guys are busy, but this was opened a month ago. Seems like this should have been merged by now.


Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub.

Contributor

aria42 commented Apr 2, 2013

I believe this has now been fixed and your test case merged in with our changes. We had a concurrent set of changes to the actual templating stuff but your test case was still useful. Thanks and sorry that took so long.

@aria42 aria42 closed this Apr 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment