From 1e4988dd832b4245f0975f783a3c7d64e5f66a6c Mon Sep 17 00:00:00 2001 From: I Ketut Sandiarsa Date: Wed, 7 Dec 2022 05:07:46 +0800 Subject: [PATCH 1/2] chore: Fix compile error on createClass function --- packages/reflect/src/helpers.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/reflect/src/helpers.ts b/packages/reflect/src/helpers.ts index 55dcca4a..2cdd2e58 100644 --- a/packages/reflect/src/helpers.ts +++ b/packages/reflect/src/helpers.ts @@ -87,8 +87,8 @@ interface CreateClassOption { function createClass(definition: CustomTypeDefinition, opt?: Partial): Class { class Base { } - const option: CreateClassOption = { extends: Base, name: "DynamicType", genericParams: [], ...opt } - const type = { [option.name]: class extends option.extends { } }[option.name]; + const {extends:BaseClass, ...option} = { extends: Base, name: "DynamicType", genericParams: [], ...opt } + const type = { [option.name]: class extends BaseClass { } }[option.name]; (type as any)[IsDynamicType] = true for (const key in definition) { Reflect.decorate([decorate.type(definition[key])], type.prototype, key) From 5ababa4d07bf5e56e956cacf3668808fb68245b5 Mon Sep 17 00:00:00 2001 From: I Ketut Sandiarsa Date: Wed, 7 Dec 2022 05:32:50 +0800 Subject: [PATCH 2/2] fix: Base class parser error --- packages/reflect/src/parser.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/reflect/src/parser.ts b/packages/reflect/src/parser.ts index 52bad12f..8b0af3e1 100644 --- a/packages/reflect/src/parser.ts +++ b/packages/reflect/src/parser.ts @@ -59,7 +59,7 @@ function getNamesFromAst(nodes: any[]) { function getCode(fn: Class | Function) { const code = fn.toString() - if (code.search(/^class(\s*)extends\s*option.extends\s*{\s*}/gm) > -1) { + if (code.search(/^class(\s*)extends\s*BaseClass\s*{\s*}/gm) > -1) { return "class DynamicClass extends Parent {}" } else