Google universal tracking #135

Merged
merged 3 commits into from Dec 16, 2013

Conversation

Projects
None yet
5 participants
@jousby

jousby commented Mar 21, 2013

Google Analytics has two options for tracking websites now. The legacy system which is now called 'classic' and the new system called 'universal tracking' which is in beta. This pull request adds support for the new universal tracking script and adds 'google_classic' and 'google_universal' as options in the providers section of the config file.

@bzz

This comment has been minimized.

Show comment
Hide comment
@bzz

bzz Nov 4, 2013

Thank you for contributing!
+1 for merging this one as this still keeps classic code and adds new universal one.
Is there anything to be done to merge\close it?

bzz commented Nov 4, 2013

Thank you for contributing!
+1 for merging this one as this still keeps classic code and adds new universal one.
Is there anything to be done to merge\close it?

@marshallshen

This comment has been minimized.

Show comment
Hide comment
@marshallshen

marshallshen Dec 16, 2013

Collaborator

@jousby , thanks for the PR!

Collaborator

marshallshen commented Dec 16, 2013

@jousby , thanks for the PR!

marshallshen added a commit that referenced this pull request Dec 16, 2013

@marshallshen marshallshen merged commit 0980641 into plusjade:jb-development Dec 16, 2013

@sapzildj

This comment has been minimized.

Show comment
Hide comment

sapzildj commented Aug 7, 2015

+1

@groundh0g groundh0g referenced this pull request Aug 9, 2015

Closed

Google Analytics UA #282

@groundh0g

This comment has been minimized.

Show comment
Hide comment
@groundh0g

groundh0g Aug 9, 2015

Collaborator

This was a PR against the jb-development branch, which ideally would be host to our features until merging into master. Unfortunately, the merge didn't have the desired effect.

Looks like the analytics stub is also in the master branch (as googleUA via PR #228), but not referenced in the analytics include or in the _config.yml. Should be a trivial matter to incorporate the edits from this PR along with #228.

I didn't realize the plumbing was disconnected earlier. Thanks for bringing attention to this.

Since both source PRs are closed, I created issue #282 to track.

Collaborator

groundh0g commented Aug 9, 2015

This was a PR against the jb-development branch, which ideally would be host to our features until merging into master. Unfortunately, the merge didn't have the desired effect.

Looks like the analytics stub is also in the master branch (as googleUA via PR #228), but not referenced in the analytics include or in the _config.yml. Should be a trivial matter to incorporate the edits from this PR along with #228.

I didn't realize the plumbing was disconnected earlier. Thanks for bringing attention to this.

Since both source PRs are closed, I created issue #282 to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment