New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing providers #90

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@tlvince

tlvince commented May 27, 2012

Issue #15 seems to be the last time discussion on sharing providers came up (which stalled after #20) and nothing seems to have happened since then.

This pull request is my take on how sharing providers could be implemented. The sharing links themselves are built from Jekyll variables and hence, this approach doesn't use any Javascript.

See my photoblog for an example of how it looks.

@groundh0g groundh0g added this to the v 0.5.0 milestone Apr 4, 2015

@groundh0g groundh0g self-assigned this Apr 4, 2015

@groundh0g

This comment has been minimized.

Show comment
Hide comment
@groundh0g

groundh0g May 25, 2015

Collaborator

I like it. Has merge conflicts now. If you're willing to resubmit, I'll merge. If you have neither the time nor desire to tweak, I'll revisit this during the next release. Thanks for the contribution!

Collaborator

groundh0g commented May 25, 2015

I like it. Has merge conflicts now. If you're willing to resubmit, I'll merge. If you have neither the time nor desire to tweak, I'll revisit this during the next release. Thanks for the contribution!

@tlvince

This comment has been minimized.

Show comment
Hide comment
@tlvince

tlvince May 25, 2015

This was submitted nearly three years to the day 😄 Feel free to rebase yourselves; I'm afraid I no longer use jekyll-bootstrap.

tlvince commented May 25, 2015

This was submitted nearly three years to the day 😄 Feel free to rebase yourselves; I'm afraid I no longer use jekyll-bootstrap.

@groundh0g

This comment has been minimized.

Show comment
Hide comment
@groundh0g

groundh0g May 25, 2015

Collaborator

Will do. Thanks for the contrib! Sorry it's taken so long to cull the issues.

Collaborator

groundh0g commented May 25, 2015

Will do. Thanks for the contrib! Sorry it's taken so long to cull the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment