Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in NamespacePrefixMapperUtils.tryRIforRelationshipsPart #380

Merged
merged 1 commit into from Feb 6, 2020

Conversation

@campbellr
Copy link
Contributor

campbellr commented Feb 6, 2020

This caused the first call to getPrefixMapperRelationshipsPart
to always return null. All subsequent calls would correctly return the
correct (cached) version.

The end result is similar to #333, where Relationship
tags are incorrectly prefixed with rel:, which breaks LibreOffice.

Except that it only occurs the first time a docx is saved.

(I assume that when it returns null, we fall back to some default mapper that adds a namespace prefix, but i didn't dig deep enough into the code to confirm...)

This caused the first call to getPrefixMapperRelationshipsPart
to always return `null`. All subsequent calls would correctly return the
correct (cached) version.

The end result is similar to #333, where Relationship
tags are incorrectly prefixed with `rel:`, which breaks LibreOffice.

Except that it only occurs the first time a docx is saved.
@campbellr campbellr requested a review from plutext Feb 6, 2020
@plutext plutext merged commit 1ded94e into plutext:master Feb 6, 2020
@plutext

This comment has been minimized.

Copy link
Owner

plutext commented Feb 6, 2020

thanks for this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.