Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back landing_page option which API v2 is supported #251

Merged
merged 1 commit into from Nov 18, 2022

Conversation

ihipop
Copy link
Contributor

@ihipop ihipop commented Nov 16, 2022

What does this PR do?

The doc reference is not correct in the code, you reference to a V1 api doc
but actually request a V2 endpoint
so LandingPage should also available but you commented it out

Where should the reviewer start?

https://developer.paypal.com/docs/api/orders/v2/#definition-application_context

https://github.com/plutov/paypal/blame/4c16ffad0a4582b3cccb13acb8f7db85b0a66ed2/types.go#L202

How should this be manually tested?

///....
appContext := &paypal.ApplicationContext{
		LandingPage:        "BILLING",
		BrandName:          "TEST",
		ShippingPreference: "NO_SHIPPING",
		ReturnURL: "https://example.com/success",
		CancelURL: "https://example.com/cancel",
	}
///....
Client.CreateOrder(ctx, paypal.OrderIntentCapture, purchaseUnits, payer, appContext)

Any background context you want to provide?

#233

image

image

@ihipop ihipop changed the title bring back landing_page option which API v2 suppotted bring back landing_page option which API v2 is supported Nov 16, 2022
@plutov plutov merged commit ebf5966 into plutov:master Nov 18, 2022
@ihipop ihipop deleted the feature/fix_missed_landing_page branch March 31, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants