Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little silly changes ... #12

Merged
merged 4 commits into from Jan 14, 2020
Merged

Little silly changes ... #12

merged 4 commits into from Jan 14, 2020

Conversation

@lguzzon
Copy link
Contributor

lguzzon commented Jan 9, 2020

No description provided.

lguzzon added 3 commits Jan 9, 2020
@ahnick

This comment has been minimized.

Copy link
Collaborator

ahnick commented Jan 13, 2020

Hi @lguzzon. Thanks for the PR. I think these are all good changes. There are some minor adjustments that I would like you to make to the PR before we merge and I have left comments on the corresponding lines.

@lguzzon

This comment has been minimized.

Copy link
Contributor Author

lguzzon commented Jan 14, 2020

Hi @lguzzon. Thanks for the PR. I think these are all good changes. There are some minor adjustments that I would like you to make to the PR before we merge and I have left comments on the corresponding lines.

Thanks, but I can't find any comments on lines ... I'm wrong or what?

Copy link
Collaborator

ahnick left a comment

Hi @lguzzon. Thanks for the PR. I think these are all good changes. There are some minor adjustments that I would like you to make to the PR before we merge and I have left comments on the corresponding lines.

Thanks, but I can't find any comments on lines ... I'm wrong or what?

If you click on "Files changed" tab above here in the PR can you see my comments for encpass.sh? They should also be showing even on this conversation tab. They do not however appear in the file if you are just looking on your local machine.

encpass.sh Outdated Show resolved Hide resolved
encpass.sh Outdated Show resolved Hide resolved
encpass.sh Outdated Show resolved Hide resolved
@lguzzon

This comment has been minimized.

Copy link
Contributor Author

lguzzon commented Jan 14, 2020

Done!!!

@ahnick ahnick merged commit 90df2c4 into plyint:master Jan 14, 2020
@ahnick

This comment has been minimized.

Copy link
Collaborator

ahnick commented Jan 14, 2020

@lguzzon Great thanks! Merged. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.