Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firefox Support #29

Merged
merged 4 commits into from Aug 26, 2017
Merged

Add Firefox Support #29

merged 4 commits into from Aug 26, 2017

Conversation

@half-duplex
Copy link
Contributor

@half-duplex half-duplex commented Jun 9, 2017

Firefox now supports WebExtensions, more or less the same as Chrome and Opera. This seems to work with no significant changes.

Also added a makefile for building the xpi, but I don't know how to package for chrome.

To test:
Clone and run make
In Firefox, go to about:debugging, click "Load temporary add-on", select xpi.
Reload a page and the indicator should appear.

@half-duplex
Copy link
Contributor Author

@half-duplex half-duplex commented Jun 9, 2017

Should have searched, #28 is related.

Loading

@pmarks-net
Copy link
Owner

@pmarks-net pmarks-net commented Jun 17, 2017

I think Firefox's implementation of the extension API is currently too buggy to merge this. I played with it for a bit on Firefox 53, and noticed the following problems:

  • Most websites (e.g. www.kernel.org) show ? until you reload the page.
  • On www.reddit.com, 5 of the domains show (no address).
  • Right-clicking an IP address from the popup doesn't display the context menu.
  • When the domain list exceeds the vertical height of the popup (e.g. on http://www.reddit.com or http://test-ipv6.com), this creates a horizontal scrollbar, when it should be vertical-only unless a very long name is present.
  • WebSocket connections (e.g. on https://www.websocket.org/echo.html) don't show the orange S icon.

So we either need to convince Mozilla to fix the bugs, or add a bunch of Firefox-specific workarounds to IPvFoo.

Loading

@pmarks-net pmarks-net merged commit 7a1f0a7 into pmarks-net:master Aug 26, 2017
@pmarks-net
Copy link
Owner

@pmarks-net pmarks-net commented Aug 26, 2017

People keep asking for this, and "perfect is the enemy of good", so I think I'll publish it despite the flaws.

Loading

@andreicristianpetcu
Copy link

@andreicristianpetcu andreicristianpetcu commented Aug 27, 2017

If you can't wait for the official one, I made an unlisted signed build enjoy!

Loading

@pmarks-net
Copy link
Owner

@pmarks-net pmarks-net commented Aug 27, 2017

https://addons.mozilla.org/en-US/firefox/addon/ipvfoo-pmarks went live this morning (the "ipvfoo" name was in use; did anyone on this thread take it?)

Loading

@half-duplex
Copy link
Contributor Author

@half-duplex half-duplex commented Aug 27, 2017

Loading

@andreicristianpetcu
Copy link

@andreicristianpetcu andreicristianpetcu commented Aug 27, 2017

Nice..... I will take down myne from GH. :)

Loading

@pmarks-net
Copy link
Owner

@pmarks-net pmarks-net commented Aug 30, 2017

I'm gathering the Firefox bugs in #32

Loading

@rotanid
Copy link

@rotanid rotanid commented Jan 16, 2018

thanks for porting this to firefox, i replaced IPvFox with your addon

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants