Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve heading anchors #183

Merged

Conversation

@SgtSilvio
Copy link
Contributor

SgtSilvio commented Aug 15, 2019

Motivation
Nice to see the inclusion of heading anchors.
I like that you use the link svg that is also used on GitHub. 馃憤
Actually the svg is included for every heading. This increases the size of the documents unnecessarily. I deduplicated the svgs using svg refs.
Additionally the anchors are now displayed if you hover over them (just like on GitHub). Previously you had to hover over the heading.

Changes

  • Anchor headings are now displayed on hover, not only on heading hover
  • Deduplicated anchor heading svg
  • Anchor heading svg is now centered for heading
Deduplicated anchor heading svg,
Anchor heading svg is now centered for heading
@pmarsceill

This comment has been minimized.

Copy link
Owner

pmarsceill commented Aug 16, 2019

Thank you for this!

@pmarsceill pmarsceill changed the base branch from master to v0.2.7-release Sep 9, 2019
@pmarsceill pmarsceill merged commit f960695 into pmarsceill:v0.2.7-release Sep 9, 2019
@pmarsceill pmarsceill mentioned this pull request Sep 9, 2019
@SgtSilvio SgtSilvio deleted the SgtSilvio:improvement/heading-anchors branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.