Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.7 release #212

Merged
merged 82 commits into from Sep 10, 2019
Merged

v0.2.7 release #212

merged 82 commits into from Sep 10, 2019

Conversation

@pmarsceill
Copy link
Owner

pmarsceill commented Sep 9, 2019

Bugs fixed

  • Anchor headings are now displayed on hover, not only on heading hover
  • Deduplicated anchor heading svg
  • If last page of site.html_pages was excluded from search, search json breaks
  • Config variable should be blanklines not blank_lines for html compression
  • list-style-none does not hide bullets on ul

Enhancements

  • Summary for child pages appears in generated TOC
  • Site logo configuration supported replacing title text with image
  • Allow custom CSS overrides (new scss partial at the end of the cascade) separate from variable overrides.
  • Configuration around search strings added to allow search for hyphenated words

Maintenance

  • Update docs to suggest using index.md as section page filename
  • Bump @primer/css from 12.6.0 to 12.7.0
  • Bump mixin-deep from 1.3.1 to 1.3.2
  • Bump stylelint-config-primer from 7.0.1 to 8.0.0

PR included

#98 by @stefanoborini Introduces the possibility for a summary in the table of contents
#141 by @ghabs Fix trailing comma bug in search-data.json
#153 by @jacobherrington Change button copy on theme preview
#181 by @m3nu Recommend using index.md as parent page for sections
#183 by @SgtSilvio Improve heading anchors
#187 by @SgtSilvio Improvement/site logo
#200 Bump mixin-deep from 1.3.1 to 1.3.2
#203 by @pdmosses Search config
#205 by @pdmosses Fix blank_lines var to blanklines in config.yml
#206 by @iamcarrico Allow for custom overrides by the user
#208 Bump @primer/css from 12.6.0 to 12.7.0
#213 Bump mixin-deep from 1.3.1 to 1.3.2
#214 Bump stylelint-config-primer from 7.0.1 to 8.0.0
#215 Bump @primer/css from 12.6.0 to 12.7.0

stefanoborini and others added 19 commits Mar 9, 2019
Adding summary for toc
Adding summary for toc - 2
If you exclude the last page in the site.html_pages through exclude_true you end up violating the assumption in the for loop that the last page won't have a trailing comma. This breaks the json data that is served to the front end.

I removed the forloop.last check and instead assign a temporary variable to check for the first non-excluded page, and then add the comma before the next non-excluded entry.
This commit makes the dark mode preview feel a little more interactive
and it also pulls some duplicated code into one file so that people like
me aren't stumped when they are looking at the wrong page!
Using `index.md` as name for the parent page within a section allows lazy developers
to skip defining `permalink`. This is already working and this PR just updates the documentation.
Deduplicated anchor heading svg,
Anchor heading svg is now centered for heading
(cherry picked from commit 2a5c389)
(cherry picked from commit 468bf83)
(cherry picked from commit 97d1c66)
A `navigation-list-child-list` is not displayed unless the enclosing `navigation-list-item` is `active`, so it needs to be generated only when `page.url == node.url or page.parent == node.title or page.grand_parent == node.title`.
Automatically replaces the title with a logo
The current default is that when a grandparent is selected, the links to its
children *and all its grandchildren* are displayed in the navigation menu.
Setting `grandchildren_branch: true` in `_config.yml` delays the display of links
to grandchildren until their parent is selected.
Separating new PR from #188, since indpendent.
@pdmosses

This comment was marked as outdated.

Copy link
Contributor Author

pdmosses commented on 8ac545a Aug 21, 2019

The current default is that when a grandparent is selected, the links to its children and all its grandchildren are displayed in the navigation menu. Setting grandchildren_branch: true in _config.yml delays the display of links to grandchildren until their parent is selected.

plancomps and others added 10 commits Aug 22, 2019
This reverts commit c282e4b.
Restrict navigation to display only direct children.
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. **This update includes a security fix.**
- [Release notes](https://github.com/jonschlinkert/mixin-deep/releases)
- [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
This reverts commit 209ac7b.
This reverts commit c282e4b.
…-deep-1.3.2

[Security] Bump mixin-deep from 1.3.1 to 1.3.2
…lint-config-primer-8.0.0

Bump stylelint-config-primer from 7.0.1 to 8.0.0
pmarsceill added 2 commits Sep 10, 2019
…r/css-12.7.0

Bump @primer/css from 12.6.0 to 12.7.0
@pmarsceill pmarsceill merged commit 8bd2da5 into master Sep 10, 2019
7 of 10 checks passed
7 of 10 checks passed
Build + Publish
Details
Build + Publish
Details
Build + Publish
Details
Build Jekyll site
Details
Build Jekyll site
Details
Build + Publish
Details
Stylelint
Details
Stylelint
Details
Page Build GitHub Pages successfully built your site.
Details
github/pages GitHub Pages successfully built your site.
Details
@pmarsceill pmarsceill deleted the v0.2.7-release branch Sep 10, 2019
@pdmosses

This comment has been minimized.

Copy link
Contributor Author

pdmosses commented on 690d0b5 Sep 10, 2019

It seems this revert on nav.html was inadvertently included in 0.2.7 (my commits got in a mess with making the original PR on my fork master, and later trying to separate it from subsequent PRs...). Apologies for not noticing this before the 0.2.7 release.

Anyway, there is now no need to reopen #173, as the issue is addressed by the recursive navigation PR #192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.