Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync entries from device to server -> timezone #105

Open
Pofilo opened this issue Feb 11, 2020 · 1 comment
Open

Sync entries from device to server -> timezone #105

Pofilo opened this issue Feb 11, 2020 · 1 comment

Comments

@Pofilo
Copy link

@Pofilo Pofilo commented Feb 11, 2020

Hello,
I'm using the last version of plop-reader with the last version of wallabag on a Touch HD Plus.
The function wallabag_api.syncEntriesToServer() is not doing anything to the server (not telling the server that an article is now marked as read).
Is someone else experiencing the issue ?

In the logs, I juste have:

[2020:02:11 22:09:21][debug] API: syncEntriesToServer()
[2020:02:11 22:09:21][debug] API: syncEntriesToServer(): done

It seems that we never enter in the loop for (unsigned int i=0 ; i<changedEntries.size() ; i++) {.
Maybe because of the function repository.findUpdatedLocallyMoreRecentlyThanRemotely(changedEntries); ?

If someone else is experiencing the issue, let me know :)
I will try to find an explanation why the changedEntries are not correctly updated.

@Pofilo

This comment has been minimized.

Copy link
Author

@Pofilo Pofilo commented Feb 12, 2020

Okay, I may have found my issue.

In the database, local_updated_at > remote_updated_at was not true because of timezones: my server is in CET timezone whereas the pocketbook (or plop reader) is in UTC/GMT.

I will provide a PR if I manage to deal properly with timezones.
Otherwise, I this is not a big deal if I'm patient between operations on the server and the pocketbook (at least one hour in winter).

@Pofilo Pofilo changed the title Sync entries from device to server Sync entries from device to server -> timezone Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.