Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not abort sync when a 404 occurs when pushing updates to server #54

Merged
merged 1 commit into from Oct 18, 2016

Conversation

@pmartin
Copy link
Owner

pmartin commented Oct 18, 2016

This is most likely caused by an entry that's been deleted on the server,
and should not abort the whole synchronisation.

Steps to reproduce the problem (before applying this PR):

  • Add an entry to wallabag
  • Sync from server to ereader
  • On the server, delete the entry
  • On the ereader, archive the same entry
  • Launch a sync on the ereader => when the ereader tries to push the "archived" info, it gets a 404 error and aborts sync.

@Ygster this relates to #53 your created a few days ago ;-)
It's not a perfect fix, but should at least help until I implement a more complete solution.

As this bug is the most critical one that's been reported for version 0.2.0, I might release a v0.2.1 minor version with this fix...

This is most likely caused by an entry that's been deleted on the server,
and should not abort the whole synchronisation.
@pmartin pmartin added bug sync labels Oct 18, 2016
@pmartin pmartin added this to the v0.2.1 milestone Oct 18, 2016
@pmartin pmartin changed the base branch from master to 2.x Oct 18, 2016
@pmartin pmartin merged commit 1416141 into 2.x Oct 18, 2016
@pmartin pmartin deleted the do-not-abort-sync-on-404-when-pushing-to-server branch Oct 18, 2016
@Ygster
Copy link

Ygster commented Oct 29, 2016

Tested, it works in my use case, Thanks ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.