Do not abort sync when a 404 occurs when pushing updates to server #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is most likely caused by an entry that's been deleted on the server, and should not abort the whole synchronisation.
|
Tested, it works in my use case, Thanks ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most likely caused by an entry that's been deleted on the server,
and should not abort the whole synchronisation.
Steps to reproduce the problem (before applying this PR):
@Ygster this relates to #53 your created a few days ago ;-)
It's not a perfect fix, but should at least help until I implement a more complete solution.
As this bug is the most critical one that's been reported for version 0.2.0, I might release a v0.2.1 minor version with this fix...