Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

bug fixes and optimizations #5

Merged
merged 8 commits into from Oct 3, 2011

Conversation

Projects
None yet
2 participants
Contributor

rip747 commented Oct 1, 2011

closes issues #1, #2, #4
compile regular expressions in constructor
optimize rendering loops

Owner

pmcelhaney commented Oct 3, 2011

Wow, thanks a lot, Tony. This is great!

I've been out of the ColdFusion world for about a year now. Would you be interested in taking ownership of this project?

Contributor

rip747 commented Oct 3, 2011

Sorry to hear that :( The code and tests you wrote were awesome and I
learned quite a bit from it . Thank you very much for this. I would be more
than willing to take over maintaining the project.
On Oct 2, 2011 8:45 PM, "Patrick McElhaney" <
reply@reply.github.com>
wrote:

Wow, thanks a lot, Tony. This is great!

I've been out of the ColdFusion world for about a year now. Would you be
interested in taking ownership of this project?

Reply to this email directly or view it on GitHub:
#5 (comment)

pmcelhaney added a commit that referenced this pull request Oct 3, 2011

Merge pull request #5 from rip747/master
bug fixes and optimizations

@pmcelhaney pmcelhaney merged commit 1b20e8a into pmcelhaney:master Oct 3, 2011

Owner

pmcelhaney commented Oct 3, 2011

Great! I appreciate that. I had a lot of fun with this project, but since I'm not doing ColdFusion at my current job it's been low on the priority list. Your pull request is an excellent piece of work, and I'm happy to hand over the reins.

(Since it's GitHub, I guess there's not really anything to hand over, but if anyone asks, I'll point them to your repo.)

Collaborator

pmcelhaney commented on tests/RenderTests.cfc in fc01be2 Oct 3, 2011

Suggestion: Make this {{^set}}No records found{{/set}}, since that's how it's used in practice (to show a message when a collection is empty).

Owner

rip747 replied Oct 3, 2011

in other words... i completely screwed up the logic here and got it backwards :P "^" should equate to "false"?

Collaborator

pmcelhaney replied Oct 3, 2011

Well, the test is still valid. ^ means not. If you make this change, the expected string should change to "Ready No records foundgo!"

Owner

rip747 replied Oct 4, 2011

will do and thank you for the code review. lord knows i need it ;)

Contributor

rip747 commented Oct 3, 2011

the thing i've seen others do is to just update the README pointing it to
the new maintainer.

On Mon, Oct 3, 2011 at 10:48 AM, Patrick McElhaney <
reply@reply.github.com>wrote:

Great! I appreciate that. I had a lot of fun with this project, but since
I'm not doing ColdFusion at my current job it's been low on the priority
list. Your pull request is an excellent piece of work, and I'm happy to hand
over the reins.

(Since it's GitHub, I guess there's not really anything to hand over, but
if anyone asks, I'll point them to your repo.)

Reply to this email directly or view it on GitHub:
#5 (comment)

markmandel referenced this pull request in markmandel/Mustache.cfc Apr 5, 2012

Merge pull request #5 from seancoyne/master
More accurate unit tests for the custom tag version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment