From db9450227dada4fdde89d92df26b968f380577dd Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Sat, 9 Sep 2023 09:58:02 +0200 Subject: [PATCH] Upgrade to node20 - also removes convert-action node20 is available since https://github.com/actions/runner/releases/tag/v2.308.0 --- .github/workflows/generate.yml | 2 +- .github/workflows/publish.yml | 2 ++ .github/workflows/test.yml | 2 +- action.yml | 4 +-- package-lock.json | 57 ---------------------------------- package.json | 3 +- 6 files changed, 7 insertions(+), 63 deletions(-) diff --git a/.github/workflows/generate.yml b/.github/workflows/generate.yml index ca8e37a..f151256 100644 --- a/.github/workflows/generate.yml +++ b/.github/workflows/generate.yml @@ -56,7 +56,7 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3.8.1 with: - node-version: 16 + node-version: 20 - name: Install dependencies run: npm ci diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index c806fe8..7fe0237 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -20,6 +20,8 @@ jobs: - name: Setup Node uses: actions/setup-node@v3.8.1 + with: + node-version: 20 # Compile dist/index.js and bundle with action.yml # Force push major and minor tags, e.g. v1, v1.0 diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index dda027b..1c4091f 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -23,6 +23,6 @@ jobs: - name: Setup Node.js uses: actions/setup-node@v3.8.1 with: - node-version: 16 + node-version: 20 - run: npm ci - run: npm test diff --git a/action.yml b/action.yml index 66f544c..2e5c117 100644 --- a/action.yml +++ b/action.yml @@ -20,7 +20,7 @@ inputs: [Learn more about creating and using encrypted secrets](https://docs.github.com/en/actions/security-guides/encrypted-secrets) required: false - default: '${{ github.token }}' + default: ${{ github.token }} version: description: >- PMD version to use. Using "latest" automatically downloads the latest @@ -86,7 +86,7 @@ outputs: violations: description: Number of violations found runs: - using: node16 + using: node20 main: dist/index.js branding: icon: code diff --git a/package-lock.json b/package-lock.json index 7d4fa84..e923f45 100644 --- a/package-lock.json +++ b/package-lock.json @@ -18,7 +18,6 @@ "devDependencies": { "@actions/io": "^1.1.3", "@vercel/ncc": "^0.38.0", - "convert-action": "^0.3.0", "eslint": "^8.49.0", "fetch-mock-jest": "^1.5.1", "jest": "^29.6.4", @@ -2077,36 +2076,6 @@ "resolved": "https://registry.npmjs.org/concat-map/-/concat-map-0.0.1.tgz", "integrity": "sha1-2Klr13/Wjfd5OnMDajug1UBdR3s=" }, - "node_modules/convert-action": { - "version": "0.3.0", - "resolved": "https://registry.npmjs.org/convert-action/-/convert-action-0.3.0.tgz", - "integrity": "sha512-VGnI3zlCMIIAHnByBKlEv8c66jG5c1UMk1lRfAy64D72btXx+lq24GDdH67fONA4DUm+ySn2FdsR1w1s3FcJ8Q==", - "dev": true, - "dependencies": { - "js-yaml": "^4.1.0" - }, - "bin": { - "convert-action": "bin.js" - } - }, - "node_modules/convert-action/node_modules/argparse": { - "version": "2.0.1", - "resolved": "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz", - "integrity": "sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q==", - "dev": true - }, - "node_modules/convert-action/node_modules/js-yaml": { - "version": "4.1.0", - "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.0.tgz", - "integrity": "sha512-wpxZs9NoxZaJESJGIZTyDEaYpl0FKSA+FB9aJiyemKhMwkxQg63h4T1KJgUGHpTqPDNRcmmYLugrRjJlBtWvRA==", - "dev": true, - "dependencies": { - "argparse": "^2.0.1" - }, - "bin": { - "js-yaml": "bin/js-yaml.js" - } - }, "node_modules/convert-source-map": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/convert-source-map/-/convert-source-map-2.0.0.tgz", @@ -6526,32 +6495,6 @@ "resolved": "https://registry.npmjs.org/concat-map/-/concat-map-0.0.1.tgz", "integrity": "sha1-2Klr13/Wjfd5OnMDajug1UBdR3s=" }, - "convert-action": { - "version": "0.3.0", - "resolved": "https://registry.npmjs.org/convert-action/-/convert-action-0.3.0.tgz", - "integrity": "sha512-VGnI3zlCMIIAHnByBKlEv8c66jG5c1UMk1lRfAy64D72btXx+lq24GDdH67fONA4DUm+ySn2FdsR1w1s3FcJ8Q==", - "dev": true, - "requires": { - "js-yaml": "^4.1.0" - }, - "dependencies": { - "argparse": { - "version": "2.0.1", - "resolved": "https://registry.npmjs.org/argparse/-/argparse-2.0.1.tgz", - "integrity": "sha512-8+9WqebbFzpX9OR+Wa6O29asIogeRMzcGtAINdpMHHyAg10f05aSFVBbcEqGf/PXw1EjAZ+q2/bEBg3DvurK3Q==", - "dev": true - }, - "js-yaml": { - "version": "4.1.0", - "resolved": "https://registry.npmjs.org/js-yaml/-/js-yaml-4.1.0.tgz", - "integrity": "sha512-wpxZs9NoxZaJESJGIZTyDEaYpl0FKSA+FB9aJiyemKhMwkxQg63h4T1KJgUGHpTqPDNRcmmYLugrRjJlBtWvRA==", - "dev": true, - "requires": { - "argparse": "^2.0.1" - } - } - } - }, "convert-source-map": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/convert-source-map/-/convert-source-map-2.0.0.tgz", diff --git a/package.json b/package.json index da28767..99d6f2f 100644 --- a/package.json +++ b/package.json @@ -4,7 +4,7 @@ "main": "dist/index.js", "scripts": { "lint": "eslint .", - "prepare": "npx ncc build lib/index.js --out dist --minify --license licenses.txt && npx convert-action", + "prepare": "npx ncc build lib/index.js --out dist --minify --license licenses.txt", "test": "jest --coverage", "all": "npm run lint && npm run prepare && npm run test" }, @@ -35,7 +35,6 @@ "devDependencies": { "@actions/io": "^1.1.3", "@vercel/ncc": "^0.38.0", - "convert-action": "^0.3.0", "eslint": "^8.49.0", "jest": "^29.6.4", "nock": "^13.3.3",