[core] Take deprecated flag into account when loading rulesets/rules

pmd · Aug 11, 2017 · ba32ed5 · ba32ed5
1 parent 2816988
commit ba32ed5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/pmd-core/src/main/java/net/sourceforge/pmd/RuleSetFactory.java b/pmd-core/src/main/java/net/sourceforge/pmd/RuleSetFactory.java
@@ -567,6 +567,10 @@ private void parseSingleRuleNode(RuleSetReferenceId ruleSetReferenceId, RuleSetB
         rule.setRuleSetName(ruleSetBuilder.getName());
         rule.setExternalInfoUrl(ruleElement.getAttribute(EXTERNAL_INFO_URL));
 
+        if (hasAttributeSetTrue(ruleElement, "deprecated")) {
+            rule.setDeprecated(true);
+        }
+
         if (hasAttributeSetTrue(ruleElement, "dfa")) {
             rule.setUsesDFA();
         }

diff --git a/pmd-core/src/test/java/net/sourceforge/pmd/RuleSetFactoryTest.java b/pmd-core/src/test/java/net/sourceforge/pmd/RuleSetFactoryTest.java
@@ -431,6 +431,7 @@ public void testInvertedMinimumMaximumLanugageVersions() throws RuleSetNotFoundE
     public void testDirectDeprecatedRule() throws RuleSetNotFoundException {
         Rule r = loadFirstRule(DIRECT_DEPRECATED_RULE);
         assertNotNull("Direct Deprecated Rule", r);
+        assertTrue(r.isDeprecated());
     }
 
     @Test