New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] CommentDefaultAccessModifier false positive with nested interfaces (regression from 6.4.0) #1211

Closed
boris-petrov opened this Issue Jun 26, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@boris-petrov

boris-petrov commented Jun 26, 2018

On PMD 6.5.0, having an interface in an interface causes that warning:

public interface A {
	interface B {
		default void b() {}
	}
}

This was not so in 6.4.0.

@adangel

This comment has been minimized.

Member

adangel commented Jun 26, 2018

Do you mean 6.5.0? If yes -> awesome for testing the new version already! If not, could you please retest with 6.5.0? Thanks!

@adangel adangel added this to the 6.6.0 milestone Jun 26, 2018

@boris-petrov boris-petrov changed the title from [java] CommentDefaultAccessModifier false positive (regression from 5.4.0) to [java] CommentDefaultAccessModifier false positive (regression from 6.4.0) Jun 26, 2018

@boris-petrov

This comment has been minimized.

boris-petrov commented Jun 26, 2018

I've edited the comment. Absolutely it is 6.5.0, sorry for the confusion. :)

@adangel adangel changed the title from [java] CommentDefaultAccessModifier false positive (regression from 6.4.0) to [java] CommentDefaultAccessModifier false positive with nested interfaces (regression from 6.4.0) Jun 26, 2018

@adangel

This comment has been minimized.

Member

adangel commented Jun 26, 2018

Thanks! Yes, this seems indeed to be an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment