New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Detector for large numbers not separated by _ #1232

Closed
boris-petrov opened this Issue Jul 9, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@boris-petrov
Copy link

boris-petrov commented Jul 9, 2018

Java allows numbers like 1000000 to be written like 1_000_000 which is much more readable. A detector that warns about numbers that have more than 3 digits not separated by _ would be nice.

@jsotuyod jsotuyod changed the title [java] [Feature request] Detector for large numbers not separated by _ [java] Detector for large numbers not separated by _ Jul 9, 2018

@jsotuyod

This comment has been minimized.

Copy link
Member

jsotuyod commented Jul 9, 2018

@boris-petrov this should be very straight forward. Anyone wanting to learn how to write a rule should look me up on gitter for some pointers.

@rajeshggwp

This comment has been minimized.

Copy link
Collaborator

rajeshggwp commented Oct 6, 2018

I'm interested in working on this!

rajeshggwp added a commit to rajeshggwp/pmd that referenced this issue Oct 14, 2018

@jsotuyod jsotuyod added the has:pr label Oct 14, 2018

@jsotuyod jsotuyod added this to the 6.9.0 milestone Oct 14, 2018

rajeshggwp added a commit to rajeshggwp/pmd that referenced this issue Oct 14, 2018

@adangel adangel modified the milestones: 6.9.0, 6.10.0 Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment