New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] XPath autocomplete arrows on first and last items #1233

Closed
oowekyala opened this Issue Jul 11, 2018 · 0 comments

Comments

1 participant
@oowekyala
Member

oowekyala commented Jul 11, 2018

The autocomplete menu displays disgracious arrows that hide other items when the last result is selected (or the first after that). Especially when there are only one or two items, this is confusing as all items end up hidden behind those arrows.

Looking into it, this is baked into the skin for ContextMenu:

http://hg.openjdk.java.net/openjfx/8/master/rt/file/f89b7dc932af/modules/controls/src/main/java/com/sun/javafx/scene/control/skin/ContextMenuContent.java#l96

For now, I think the simplest way to fix that may be creating our own skin (simplest, but not simple)...
Unfortunately we wouldn't be able to rely on the javafx implementations since they were completely shuffled around between release 1.8 and 9.

Edit: When the mouse is casually set somewhere over the contextmenu at the location where the arrow menu items appear, the apparition of the arrow menu items makes the view jump to top or bottom. Keyboard navigation is very impacted, eg sometimes pressing ARROW_DOWN selects the item above the current one

@oowekyala oowekyala added the in:ui label Jul 11, 2018

@oowekyala oowekyala added this to To do in Rule Designer via automation Jul 15, 2018

@oowekyala oowekyala moved this from To do to In progress in Rule Designer Jul 15, 2018

Rule Designer automation moved this from In progress to Done Jul 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment