New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Update CommentDefaultAccessModifierRule to extend AbstractIgnoredAnnotationRule #1343

Closed
jsotuyod opened this Issue Sep 11, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@jsotuyod
Member

jsotuyod commented Sep 11, 2018

CommentDefaultAccessModifierRule currently ignores nodes annotated with @VisibleForTesting, but does so in a very ad-hoc (and undocumented) way.

We should rework it to extend AbstractIgnoredAnnotationRule instead which will:

  • make it customizable
  • document the behavior in the properties

It would be a nice time to revamp the description to mention this exception to the rule.

@adangel adangel changed the title from [java] update CommentDefaultAccessModifierRule to extend AbstractIgnoredAnnotationRule to [java] Update CommentDefaultAccessModifierRule to extend AbstractIgnoredAnnotationRule Sep 12, 2018

@CrazyUnderdog

This comment has been minimized.

Contributor

CrazyUnderdog commented Oct 19, 2018

Hi,
is this issue still opened?

@adangel

This comment has been minimized.

Member

adangel commented Oct 19, 2018

Yes, this task still needs to be worked on...

@adangel adangel added the has:pr label Oct 19, 2018

@adangel adangel added this to the 6.9.0 milestone Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment