New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] JUnitTestsShouldIncludeAssert: Support AssertJ soft assertions #1435

Closed
adangel opened this Issue Nov 5, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@adangel
Copy link
Member

adangel commented Nov 5, 2018

Rule: JUnitTestsShouldIncludeAssert

Description:

Using Soft Assertions shouldn't trigger the rule, since these are assertions, too.

Code Sample demonstrating the issue:

import org.assertj.core.api.SoftAssertions;
import org.junit.jupiter.api.Test;
class FooTest {
    @Test
    void testFoo() {
        var softly = new SoftAssertions();
        softly.assertThat("doesn't matter").isEqualTo("doesn't matter");
        softly.assertAll();
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment