New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Turn property descriptor util into an enum and enrich its interface #763

Closed
oowekyala opened this Issue Nov 27, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@oowekyala
Member

oowekyala commented Nov 27, 2017

This is to ease the writing of UIs to edit properties for XPath rules specifically (eg the designer).

The current utility to maintain the mappings from XPath property type ids to property extractors (PropertyDescriptorUtil) gives out very little info on the descriptors that each type id build, which makes it necessary to hardcode behaviour in the designer. It would be more convenient for everyone to have an enum, instead of a bare map, the constants of which can be enriched with other relevant info.

This can be considered a follow-up on #758, #736, and somewhat related to #504,though I see no reason to schedule it for 6.0.0. The simplest is probably to tackle this along with #762.

Sorry @adangel, these changes should really have been appended to #758...

oowekyala added a commit to oowekyala/pmd that referenced this issue Nov 28, 2017

oowekyala added a commit to oowekyala/pmd that referenced this issue Nov 28, 2017

@adangel adangel added this to the 6.0.0 milestone Dec 9, 2017

@adangel adangel closed this in #764 Dec 9, 2017

adangel added a commit that referenced this issue Dec 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment