Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Fix parser error (issue 1530) #110

Merged
merged 2 commits into from Oct 16, 2016

Conversation

Projects
None yet
2 participants
@jsotuyod
Copy link
Member

commented Oct 12, 2016

  • Added a test case to show the regression
  • Changed the grammar to handle it properly

I don't fully understand why JavaCC fails to properly use the syntactic lookahead, but it's fully working. All tests green.

jsotuyod added some commits Oct 12, 2016

Replace syntactic lookahead with semantic one
 - They are the same, but JavaCC seems to handle this one better.

@adangel adangel changed the title Fix issue 1530 [java] Fix parser error (issue 1530) Oct 16, 2016

@adangel

This comment has been minimized.

Copy link
Member

commented Oct 16, 2016

Thanks!

@adangel adangel merged commit a10f98e into pmd:master Oct 16, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsotuyod jsotuyod deleted the Monits:issue-1530 branch Oct 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.