[java] Fix ClassCastException on CloneMethodMustImplementCloneable #112

Merged
merged 1 commit into from Oct 29, 2016

Projects

None yet

2 participants

@jsotuyod
Member
  • Java 8 code allows for things such as
    class UnmodifiableList<T> implements @Readonly List<@Readonly T> {}
    where not all token in the ASTImplementsList are ASTClassOrInterfaceType

I took the chance to fix indentation of this file since it was messy. Important changes are lines 37-43 (diff ignoring whitespace)

@jsotuyod jsotuyod Fix ClassCastException on CloneMethodMustImplementCloneable
 - Java 8 code allows for things such as
    `class UnmodifiableList<T> implements @Readonly List<@Readonly T> {}`
    where not all token in the ASTImplementsList are ASTClassOrInterfaceType
3774a22
@adangel adangel changed the title from Fix ClassCastException on CloneMethodMustImplementCloneable to [java] Fix ClassCastException on CloneMethodMustImplementCloneable Oct 29, 2016
@adangel
Member
adangel commented Oct 29, 2016

Thanks!

@adangel adangel merged commit 3774a22 into pmd:master Oct 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jsotuyod jsotuyod deleted the Monits:cmmic-java8-compat branch Oct 29, 2016
@jsotuyod
Member

Thanks to you for your amazing work.

With these 2 PRs, there are only 6 to go now. Is there anything I can do to make it easier on you to review / merge my PRs? Please, feel free to provide me with any feedback / requests. If I happen to have the time, I'll happily do it. I'm eager to get a 5.5.2 release with all these changes, and keep pushing it forward.

@adangel
Member
adangel commented Oct 30, 2016

Hi, thanks for your PRs! The performance improvements are really great!
I'll try to release 5.5.2 as soon as possible ;)

@jsotuyod
Member

I'm really glad to help. With everything merged, I'm eager to keep pushing performance. I've a bunch of sample projects for which I'd love to gave pmd run even faster.

Feel free to contact me with your roadmap for PMD. I'll gladly contribute to it as much as I do to my own priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment