Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[ui] XPath AutoComplete #1182
So the feature is in very early stages as we discussed the basic rudimentary setup is there I have used a basic contains check to look out for the suggestions of XPath.
Working on the UI that's a part I need help around @oowekyala
I have pushed some changes as you mentioned @oowekyala but there are still a couple left working on the following
Will be pushing some more changes at night.
The feature is not far from fully usable.
There are still a few bugs, eg.
Exception in thread "JavaFX Application Thread" java.lang.StringIndexOutOfBoundsException: String index out of range: 46 at java.lang.String.substring(String.java:1963) at net.sourceforge.pmd.util.fxdesigner.XPathPanelController.lambda$initialize$5(XPathPanelController.java:145) at org.reactfx.MappedStream.lambda$observeInputs$0(MappedStream.java:25)
Another thing is that sometimes the caret jumps at index 0. Can you investigate that?
Thanks for your efforts @akshatbahety
@akshatbahety I pushed a merge and a bugfix, please pull before doing additionnal changes
There's still something weird about the contextmenu, though atm I don't know how to work around it. When you select the last item in the dropdown other items are replaced with an up-arrow, which is not cool, especially when there's a single result.
Also, the build fails, because of PMD violations:
Other than than I think you're nearly done. The code needs to be modularized, and some other things need to be done before it's released, but I could do that myself. For example, I think the