New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [GSoC] Upload baseline of pmdtester automatically #1250

Merged
merged 2 commits into from Jul 23, 2018

Conversation

Projects
None yet
2 participants
@djydewang
Member

djydewang commented Jul 20, 2018

This is one of the tasks of the third phase of the pmdtester project. The PR is WIP.

@adangel adangel added the is:WIP label Jul 21, 2018

xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd">
<description>Every Java Rule in PMD</description>

This comment has been minimized.

@adangel

adangel Jul 21, 2018

Member

We can add in the description, that this is used for the regression tests with pmdtester

@@ -27,8 +27,21 @@ TRAVIS_COMMIT_RANGE=${TRAVIS_COMMIT_RANGE}"
fi
}
function upload_baseline() {
cd ..
pmdtester -r ./pmd -p ${TRAVIS_BRANCH} -pc ./pmd/.travis/all-java.xml -l ./pmd/.travis/project-list.xml -f

This comment has been minimized.

@adangel

adangel Jul 21, 2018

Member

Don't we need here -m single?

@@ -27,8 +27,21 @@ TRAVIS_COMMIT_RANGE=${TRAVIS_COMMIT_RANGE}"
fi
}
function upload_baseline() {

This comment has been minimized.

@adangel

adangel Jul 21, 2018

Member

We'll probably need to execute the commands here in a subshell and disable fast-fail, too.
Otherwise, the whole script will exit when the first command fails (e.g. rsync uploading to sourceforge) and we won't be able to react on $? exit codes.

Have a look at line 74 https://github.com/pmd/pmd/pull/1250/files#diff-999b8b90ab0a1755791c28e780bd4ef2R74 to see an example.

This comment has been minimized.

@adangel

adangel Jul 23, 2018

Member

Ah, I see, it's now inside the subshell together with the other calls to sourceforge. 👍

@adangel adangel self-assigned this Jul 23, 2018

@adangel adangel removed the is:WIP label Jul 23, 2018

@adangel

Looks good. I'll merge it tonight.

@adangel adangel changed the title from [GSOC] Upload baseline of pmdtester automatically to [ci] [GSoC] Upload baseline of pmdtester automatically Jul 23, 2018

@adangel adangel merged commit f49cd01 into pmd:master Jul 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

adangel added a commit that referenced this pull request Jul 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment