New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsp] #1276 add support for jspf and tag extensions #1277

Merged
merged 1 commit into from Aug 4, 2018

Conversation

Projects
None yet
4 participants
@jordillachmrf
Contributor

jordillachmrf commented Aug 1, 2018

PR Description:
Pmd-Jsp only support .jsp files but .jspf (jsp fragment) and also .tag extensions are valid
Both extensions are mentioned in sections E.16.48 and JSP.1.1.8 of the JSP spec http://download.oracle.com/otn-pub/jcp/jsp-2_3-mrel2-eval-spec/JSP2.3MR.pdf

Resolves #1276

@jordillachmrf

This comment has been minimized.

Contributor

jordillachmrf commented Aug 1, 2018

Seems that Travis deploy stage has failed ... I think that it's totally unrelated to my changes

@adangel

This comment has been minimized.

Member

adangel commented Aug 1, 2018

Yes, travis failure is probably unrelated (there was a temporary github outage) - I've started it again.

@pmd-bot

This comment has been minimized.

Contributor

pmd-bot commented Aug 2, 2018

1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

@jsotuyod jsotuyod added this to the 6.7.0 milestone Aug 4, 2018

@jsotuyod jsotuyod merged commit 57cba95 into pmd:master Aug 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
danger/danger All green. Woo!
Details

jsotuyod added a commit that referenced this pull request Aug 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment