New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Improve danger message #1339

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
3 participants
@djydewang
Member

djydewang commented Sep 10, 2018

@pmd-test

This comment has been minimized.

pmd-test commented Sep 10, 2018

1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

@djydewang djydewang added the is:WIP label Sep 10, 2018

@adangel

This comment has been minimized.

Member

adangel commented Sep 11, 2018

Preview is visible here: #1280 (comment)

@djydewang djydewang force-pushed the djydewang:improve_danger_message branch from d8b300f to b3a78c4 Sep 12, 2018

@djydewang djydewang removed the is:WIP label Sep 12, 2018

@djydewang djydewang requested a review from adangel Sep 13, 2018

@adangel

Looks good, I'm going to merge it now. Thanks!

@@ -1,6 +1,6 @@
source 'https://rubygems.org/'

gem 'pmdtester', '~> 1.0.0.pre.beta3'
gem 'pmdtester', :git => 'https://github.com/pmd/pmd-regression-tester.git'

This comment has been minimized.

@adangel

adangel Sep 14, 2018

Member

At some point, we should go back to a fixed version. But let's use the snapshot version for a while and test it that way.

@adangel adangel merged commit b3a78c4 into pmd:master Sep 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

adangel added a commit that referenced this pull request Sep 14, 2018

@adangel adangel added this to the 6.8.0 milestone Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment