New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Improved message for GuardLogStatement rule #1383

Merged
merged 1 commit into from Oct 14, 2018

Conversation

Projects
None yet
3 participants
@fblampe
Contributor

fblampe commented Oct 14, 2018

Resolves #1202 complaining about the message of the GuardLogStatement rule.

@pmd-test

This comment has been minimized.

pmd-test commented Oct 14, 2018

1 Message
📖 This changeset introduces 238 new violations and 0 new errors,
removes 238 violations and 2 errors. Full report

Generated by 🚫 Danger

@jsotuyod jsotuyod added this to the 6.9.0 milestone Oct 14, 2018

@jsotuyod

This comment has been minimized.

Member

jsotuyod commented Oct 14, 2018

@fblampe thanks for the PR, this looks great!

@jsotuyod jsotuyod changed the title from [java] Improved message for GuardLogStatement rule (Issue #1202). to [java] Improved message for GuardLogStatement rule Oct 14, 2018

@jsotuyod jsotuyod merged commit e8ac08c into pmd:master Oct 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jsotuyod added a commit that referenced this pull request Oct 14, 2018

@fblampe

This comment has been minimized.

Contributor

fblampe commented Oct 15, 2018

Awesome, thanks for the quick response and merge!
Glad I could help out a little for a tool that's so useful to me every day.

@fblampe fblampe deleted the fblampe:better-guard-lock-msg branch Oct 15, 2018

@jsotuyod

This comment has been minimized.

Member

jsotuyod commented Oct 16, 2018

@fblampe thank you for your time! If you enjoyed working on it, there are plenty of other good first issues to get your hands dirty. I'm on gitter if you need help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment