New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] [cpd] Add CPD support for Antlr based grammar on Golang #1386

Merged
merged 2 commits into from Oct 15, 2018

Conversation

Projects
None yet
3 participants
@matifraga
Contributor

matifraga commented Oct 14, 2018

Before submitting a PR, please check that:

  • The PR is submitted against master. The PMD team will merge back to support branches as needed.
  • ./mvnw clean verify passes. This will build and test PMD, execute PMD and checkstyle rules. Check this for more info

PR Description:

Hi, here is team raptor again, we are adding CPD support for Golang based on an Antlr grammar. This is the first step in order to make Golang our first Antlr-based supported language for PMD rules. Our next steps towards that goal will include some changes over PMD to allow Antlr-based languages to be supported, and finally adding Golang as an example.

@matifraga matifraga force-pushed the teamraptor:cpd-go branch from 35df05c to 4cab1ce Oct 15, 2018

@matifraga matifraga force-pushed the teamraptor:cpd-go branch from 4cab1ce to f8158c3 Oct 15, 2018

@pmd-test

This comment has been minimized.

pmd-test commented Oct 15, 2018

1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

@jsotuyod

This is really sweet!

public static final String TERSE_NAME = "go";
/**
* Create a new instance of Swift Language Module.

This comment has been minimized.

@jsotuyod

jsotuyod Oct 15, 2018

Member

copy paste from swift?

This comment has been minimized.

@matifraga

matifraga Oct 16, 2018

Contributor

🙈

*/
public GoLanguageModule() {
super(NAME, null, TERSE_NAME, null, "go");
addVersion("", null, true);

This comment has been minimized.

@jsotuyod

jsotuyod Oct 15, 2018

Member

the current version of the go Language is 1 according to their docs: https://golang.org/doc/go1compat

@jsotuyod jsotuyod added this to the 6.9.0 milestone Oct 15, 2018

@jsotuyod jsotuyod self-assigned this Oct 15, 2018

@jsotuyod jsotuyod changed the title from [GO] [CPD] Add CPD support for Antlr based grammar on Golang to [go] [cpd] Add CPD support for Antlr based grammar on Golang Oct 15, 2018

@jsotuyod

This comment has been minimized.

Member

jsotuyod commented Oct 15, 2018

I'll fix as I merge

@jsotuyod jsotuyod merged commit f8158c3 into pmd:master Oct 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jsotuyod added a commit that referenced this pull request Oct 15, 2018

@matifraga matifraga deleted the teamraptor:cpd-go branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment