New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Upgrading SLF4J from 1.7.12 to 1.7.25 #1398

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@Thunderforge
Contributor

Thunderforge commented Oct 17, 2018

Upgrading SLF4J from 1.7.12 (released March 2015) to 1.7.25 (released March 2017).

Ran mvnw.cmd clean verify and it built successfully.

@pmd-test

This comment has been minimized.

pmd-test commented Oct 17, 2018

1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

@adangel

Looks fine, thanks!

FYI - we are currently using slf4j-api only with scope test, so that it is available on the classpath during unit testing and typeresolution works for the logging rules. In future, we might use slf4j for real...

@adangel adangel self-assigned this Oct 17, 2018

@adangel adangel added this to the 6.9.0 milestone Oct 17, 2018

@adangel adangel changed the title from Upgrading SLF4J from 1.7.12 to 1.7.25 to [all] Upgrading SLF4J from 1.7.12 to 1.7.25 Oct 17, 2018

@adangel adangel merged commit 466639f into pmd:master Oct 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

adangel added a commit that referenced this pull request Oct 17, 2018

@Thunderforge Thunderforge deleted the Thunderforge:upgrade-to-slf4j-1.7.25 branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment