New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Fix XSS on documentation web page #1464

Merged
merged 1 commit into from Nov 15, 2018

Conversation

Projects
None yet
3 participants
@marob
Copy link
Contributor

marob commented Nov 15, 2018

Before submitting a PR, please check that:

  • The PR is submitted against master. The PMD team will merge back to support branches as needed.
  • ./mvnw clean verify passes. This will build and test PMD, execute PMD and checkstyle rules. Check this for more info

PR Description:

Ironically, the corresponding documentation page (https://pmd.github.io/latest/pmd_rules_jsp_security.html#nounsanitizedjspexpression) is subject to XSS!

@pmd-test

This comment has been minimized.

Copy link

pmd-test commented Nov 15, 2018

1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

@jsotuyod jsotuyod changed the title [Doc] Fix XSS on documentation web page [doc] Fix XSS on documentation web page Nov 15, 2018

@jsotuyod jsotuyod merged commit e42564c into pmd:master Nov 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jsotuyod added a commit to Monits/pmd that referenced this pull request Nov 15, 2018

@jsotuyod jsotuyod added this to the 6.10.0 milestone Nov 15, 2018

@jsotuyod

This comment has been minimized.

Copy link
Member

jsotuyod commented Nov 15, 2018

@marob thanks! This is embarrassing!

@adangel adangel referenced this pull request Nov 15, 2018

Closed

[doc] Missing escaping leads to XSS #1468

2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment