New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Configurable max loops in DAAPathFinder #1469

Merged
merged 2 commits into from Nov 26, 2018

Conversation

Projects
None yet
4 participants
@albfernandez
Copy link
Contributor

albfernandez commented Nov 15, 2018

Make maxLoops configurable in DAAPathFinder.

With the fixed value of 100, we're limited to work on code blocks of about 100 lines.

Making it configurable allows the caller to decide to work with more lines (decide the balance between more lines or faster processing)

@pmd-test

This comment has been minimized.

Copy link

pmd-test commented Nov 15, 2018

1 Message
📖 This changeset introduces 0 new violations and 0 new errors,
removes 0 violations and 0 errors. Full report

Generated by 🚫 Danger

@adangel adangel self-assigned this Nov 25, 2018

@adangel adangel added this to the 6.10.0 milestone Nov 25, 2018

@adangel
Copy link
Member

adangel left a comment

@albfernandez Thanks, this looks good, I'll merge it.

Could you explain your use case maybe?
How do you currently use DAAPathFinder? Are you working on custom rules?

@adangel adangel merged commit ae3adf7 into pmd:master Nov 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

adangel added a commit that referenced this pull request Nov 26, 2018

@albfernandez

This comment has been minimized.

Copy link
Contributor

albfernandez commented Nov 26, 2018

I use it on a custom rule used to find sq-injection and XSS

https://github.com/albfernandez/GDS-PMD-Security-Rules

We are analyzing a large code repository and some code is not good, with some very large functions. Then the analysis is cut at 100 lines, and we need to analyze the whole function/block (or with this path we can configure the balance)

Thanks for merging

@albfernandez albfernandez deleted the albfernandez:ConfigMaxLoopsPathFinder branch Nov 26, 2018

@jsotuyod

This comment has been minimized.

Copy link
Member

jsotuyod commented Jan 13, 2019

@albfernandez those rules seem very interesting... our security category for Java is currently lacking. Would you be interested in contributing them back to the main PMD project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment