New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] 1151: Rephrase ImmutableField documentation in design.xml #1494

Merged
merged 1 commit into from Dec 2, 2018

Conversation

Projects
None yet
3 participants
@rmartinus
Copy link
Contributor

rmartinus commented Dec 2, 2018

Fixes #1151

@pmd-test

This comment has been minimized.

Copy link

pmd-test commented Dec 2, 2018

1 Message
📖 This changeset introduces 0 new violations and 0 new errors,
removes 0 violations and 2 errors. Full report

Generated by 🚫 Danger

@rmartinus

This comment has been minimized.

Copy link
Contributor

rmartinus commented Dec 2, 2018

@jsotuyod when you get a chance please review this PR. Thank you.

@adangel adangel self-assigned this Dec 2, 2018

@adangel adangel added this to the 6.10.0 milestone Dec 2, 2018

@adangel

adangel approved these changes Dec 2, 2018

Copy link
Member

adangel left a comment

Looks good!
Congrats to your first contribution! 🎉

@rmartinus

This comment has been minimized.

Copy link
Contributor

rmartinus commented Dec 2, 2018

Thank you!

@adangel adangel merged commit f030e66 into pmd:master Dec 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

adangel added a commit that referenced this pull request Dec 2, 2018

@rmartinus rmartinus deleted the rmartinus:1151-rephrase-ImmutableField-documentation branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment