New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: simplify names of a few common functions #75

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
4 participants
@pbalcer
Contributor

pbalcer commented Oct 1, 2018

This just a small cleanup of function names that in retrospect
were badly choosen ;)
'pool::get_root' -> 'pool::root'
'pool::get_handle' -> 'pool::handle'
'transaction::get_last_tx_error' -> 'transaction::error'
'transaction::exec_tx' -> 'transaction::run'

Because the old names are present, but deprecated by compiler function attributes, this might break dependent builds that use -Werror.


This change is Reviewable

@pmem-bot

This comment has been minimized.

Contributor

pmem-bot commented Oct 1, 2018

@igchor and @Greg091 please review this pull request

@marcinslusarz

Reviewed 46 of 47 files at r1.
Reviewable status: 46 of 47 files reviewed, 1 unresolved discussion (waiting on @pbalcer)


include/libpmemobj++/detail/common.hpp, line 46 at r1 (raw file):

#if defined(__GNUC__) || defined(__clang__)
#define DEPRECATED __attribute__((deprecated))

This name may clash with other header. POBJCPP_DEPRECATED?

@pbalcer

Reviewable status: 46 of 47 files reviewed, 1 unresolved discussion (waiting on @pbalcer)


include/libpmemobj++/detail/common.hpp, line 46 at r1 (raw file):

Previously, marcinslusarz (Marcin Ślusarz) wrote…

This name may clash with other header. POBJCPP_DEPRECATED?

POBJ_CPP_DEPRECATED ?

@marcinslusarz

This comment has been minimized.

Member

marcinslusarz commented Oct 1, 2018


include/libpmemobj++/detail/common.hpp, line 46 at r1 (raw file):

Previously, pbalcer (Piotr Balcer) wrote…

POBJ_CPP_DEPRECATED ?

+1

@pbalcer

Reviewable status: 44 of 47 files reviewed, 1 unresolved discussion (waiting on @marcinslusarz)


include/libpmemobj++/detail/common.hpp, line 46 at r1 (raw file):

Previously, marcinslusarz (Marcin Ślusarz) wrote…

+1

Done.

@marcinslusarz

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@igchor

:lgtm:

Reviewed 44 of 47 files at r1, 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

common: simplify names of a few common functions
This just a small cleanup of function names that in retrospect
were badly choosen ;)
'pool::get_root' -> 'pool::root'
'pool::get_handle' -> 'pool::handle'
'transaction::get_last_tx_error' -> 'transaction::error'
'transaction::exec_tx' -> 'transaction::run'
@codecov

This comment has been minimized.

codecov bot commented Oct 2, 2018

Codecov Report

Merging #75 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   90.18%   90.17%   -0.01%     
==========================================
  Files          26       26              
  Lines         988      987       -1     
==========================================
- Hits          891      890       -1     
  Misses         97       97
Flag Coverage Δ
#tests_clang_debug_cpp17 61.8% <100%> (-0.1%) ⬇️
#tests_clang_release 61.39% <100%> (-0.11%) ⬇️
#tests_gcc_debug 92.84% <100%> (-0.01%) ⬇️
#tests_gcc_release_cpp17 88.6% <100%> (ø) ⬆️
Impacted Files Coverage Δ
include/libpmemobj++/detail/common.hpp 83.33% <ø> (ø) ⬆️
...lude/libpmemobj++/make_persistent_array_atomic.hpp 94.73% <100%> (ø) ⬆️
include/libpmemobj++/make_persistent_atomic.hpp 90.9% <100%> (ø) ⬆️
include/libpmemobj++/pool.hpp 96.66% <100%> (ø) ⬆️
include/libpmemobj++/transaction.hpp 79.48% <100%> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e242ab...3baaac2. Read the comment docs.

@marcinslusarz

Reviewed 7 of 7 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@marcinslusarz marcinslusarz merged commit f6b9003 into pmem:master Oct 2, 2018

5 checks passed

code-review/reviewable 47 files reviewed
Details
codecov/patch 100% of diff hit (target 90.18%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +9.81% compared to 9e242ab
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment