Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
- Coverage 78.61% 78.59% -0.03%
==========================================
Files 75 75
Lines 11388 11391 +3
Branches 1570 1570
==========================================
Hits 8953 8953
- Misses 1842 1843 +1
- Partials 593 595 +2
Continue to review full report at Codecov.
|
|
Please also revert libattr1-dev installation from Docker images. |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
d29af4e
to
bb5140c
Compare
|
tests/preload/xattr/xattr.c, line 48 at r2 (raw file):
If this file is not buggy anymore you should a) put it in a proper place in the include list and b) trim the list of header files. If it still is, then don't remove the comment. Comments from Reviewable |
Also removing libattr-dev from the list of packages to be installed for docker builds. The confusion was due debian/ubuntu not providing a man page for setxattr/getxattr by default, and a man page installed with libattr-dev. This man page suggests the attr/xattr.h header.
bb5140c
to
116bc41
Compare
|
Review status: 0 of 8 files reviewed at latest revision, 1 unresolved discussion. tests/preload/xattr/xattr.c, line 48 at r2 (raw file): Previously, marcinslusarz (Marcin Ślusarz) wrote…
I managed to get rid of Comments from Reviewable |
|
Reviewed 7 of 7 files at r2, 1 of 1 files at r3. Comments from Reviewable |
|
@sarahjelinek Please take a look at this PR ASAP. It's affecting all Jenkins jobs. |
|
|
|
Review status: Comments from Reviewable |
Ref: #252
This change is