This repository has been archived by the owner on Mar 22, 2023. It is now read-only.
Make the documentation build reproducibly #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinslusarz
approved these changes
Mar 2, 2020
There was a problem hiding this comment.
Could you please rebase it to stable-1.1 branch instead of master?
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Whilst working on the Reproducible Builds effort [0] we noticed that pmemkv could not be built reproducibly. This is because, whilst it used the date in manpages from SOURCE_DATE_EPOCH [1] (ie. the `dt` variable), it used the current build year when templating the `year` variable. This was originally filed in Debian as #952990 [2]. [0] https://reproducible-builds.org/ [1] https://reproducible-builds.org/specs/source-date-epoch/ [2] https://bugs.debian.org/952990
lamby
force-pushed
the
952990-pmemkv-please-make-the-build-reproducible
branch
from
1927143
to
756df0a
Compare
Codecov Report
@@ Coverage Diff @@
## master #615 +/- ##
==========================================
- Coverage 85.25% 82.62% -2.64%
==========================================
Files 17 17
Lines 1723 1652 -71
==========================================
- Hits 1469 1365 -104
- Misses 254 287 +33
|
|
Sure; rebased against |
Thanks a lot |
lamby
changed the title
tasmo
pushed a commit
to prototypefund/reproducible-website
that referenced
this pull request
Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort we noticed that pmemkv could not be built reproducibly.
This is because, whilst it used the date in manpages from SOURCE_DATE_EPOCH (ie. the
dtvariable), it used the current build year when templating theyearvariable.This was originally filed in Debian as #952990.
This change is