Conversation
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 35.82% 38.58% +2.75%
==========================================
Files 21 22 +1
Lines 2127 2229 +102
==========================================
+ Hits 762 860 +98
- Misses 1365 1369 +4
Continue to review full report at Codecov.
|
948a1cb
to
aa421bc
Compare
Please rebase. |
aa421bc
to
3e921ea
Compare
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ldorau)
tests/vmemcache_test_mt.c, line 210 at r1 (raw file):
} srand((unsigned)time(NULL));
I prefer to initialize pseudo-random generator with seed with guarantees a test to be repeatable. e.g. 0
tests/vmemcache_test_mt.c, line 224 at r1 (raw file):
} memset(buffs[i].buff, 0xCC, buffs[i].size);
Maybe it is also a good idea to store various patterns in each buffer?
tests/vmemcache_test_mt.c, line 230 at r1 (raw file):
if (threads == NULL) { FATAL("out of memory"); goto exit_free_ctx;
exit_free_buffs
/* run all tests */ | ||
run_test_put(n_threads, threads, ctx); | ||
run_test_get(cache, n_threads, threads, ctx); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be good to have also a mix workload (get/put) and mix with evict workload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be added in the next PR, because it requires this fix: #27 to be merged first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @janekmi, @ldorau, and @pbalcer)
tests/vmemcache_test_mt.c, line 210 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
I prefer to initialize pseudo-random generator with seed with guarantees a test to be repeatable. e.g. 0
👍 better yet, let's just make this an option that defaults to 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @janekmi, @ldorau, and @pbalcer)
tests/vmemcache_test_mt.c, line 250 at r1 (raw file):
Previously, pbalcer (Piotr Balcer) wrote…
it would be good to have also a mix workload (get/put) and mix with evict workload.
👍
644ea61
to
8efa9dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 4 unresolved discussions (waiting on @janekmi and @pbalcer)
tests/vmemcache_test_mt.c, line 210 at r1 (raw file):
Previously, pbalcer (Piotr Balcer) wrote…
👍 better yet, let's just make this an option that defaults to 0.
Done.
tests/vmemcache_test_mt.c, line 224 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
Maybe it is also a good idea to store various patterns in each buffer?
It does not matter in this case.
tests/vmemcache_test_mt.c, line 230 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
exit_free_buffs
Done.
tests/vmemcache_test_mt.c, line 250 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
👍
It will be added in the next PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 4 unresolved discussions (waiting on @janekmi and @pbalcer)
tests/vmemcache_test_mt.c, line 250 at r1 (raw file):
Previously, ldorau (Lukasz Dorau) wrote…
It will be added in the next PR
... because it requires this fix: #27 to be merged first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pbalcer)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pbalcer)
8efa9dc
to
7e4be0f
Compare
@pbalcer please resolve your 1 discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is