IPv6: Set localhost and wildcard constants

Use IPv6 values for these. Requires updates of numerous golden files and to upstream, this needs to be configurable, based on the IP mode desired by the user.
pmichali · Mar 5, 2018 · 814036f · 814036f
1 parent 65dc3e9
commit 814036f
Show file tree

Hide file tree

Showing 56 changed files with 18,346 additions and 18,346 deletions.
diff --git a/pilot/pkg/proxy/envoy/v1/resources.go b/pilot/pkg/proxy/envoy/v1/resources.go
@@ -106,10 +106,10 @@ const (
 	RedisDefaultOpTimeout = 30 * time.Second
 
 	// WildcardAddress binds to all IP addresses
-	WildcardAddress = "0.0.0.0"
+	WildcardAddress = "[::]"
 
 	// LocalhostAddress for local binding
-	LocalhostAddress = "127.0.0.1"
+	LocalhostAddress = "[::1]"
 
 	// EgressTraceOperation denotes the name of trace operation for Envoy
 	EgressTraceOperation = "egress"

diff --git a/pilot/pkg/proxy/envoy/v1/testdata/envoy-sidecar-auth.json.golden b/pilot/pkg/proxy/envoy/v1/testdata/envoy-sidecar-auth.json.golden
@@ -6,7 +6,7 @@
   },
   "admin": {
     "access_log_path": "/dev/stdout",
-    "address": "tcp://127.0.0.1:15000"
+    "address": "tcp://[::1]:15000"
   },
   "cluster_manager": {
     "clusters": [

diff --git a/pilot/pkg/proxy/envoy/v1/testdata/envoy-sidecar.json.golden b/pilot/pkg/proxy/envoy/v1/testdata/envoy-sidecar.json.golden
@@ -6,7 +6,7 @@
   },
   "admin": {
     "access_log_path": "/dev/stdout",
-    "address": "tcp://127.0.0.1:15000"
+    "address": "tcp://[::1]:15000"
   },
   "cluster_manager": {
     "clusters": [

diff --git a/pilot/pkg/proxy/envoy/v1/testdata/lds-httpproxy.json.golden b/pilot/pkg/proxy/envoy/v1/testdata/lds-httpproxy.json.golden
@@ -1,8 +1,8 @@
 {
   "listeners": [
    {
-    "address": "tcp://127.0.0.1:15002",
-    "name": "http_127.0.0.1_15002",
+    "address": "tcp://[::1]:15002",
+    "name": "http_[::1]_15002",
     "filters": [
      {
       "type": "read",

diff --git a/pilot/pkg/proxy/envoy/v1/testdata/lds-ingress.json.golden b/pilot/pkg/proxy/envoy/v1/testdata/lds-ingress.json.golden
@@ -1,8 +1,8 @@
 {
   "listeners": [
    {
-    "address": "tcp://0.0.0.0:80",
-    "name": "http_0.0.0.0_80",
+    "address": "tcp://[::]:80",
+    "name": "http_[::]_80",
     "filters": [
      {
       "type": "read",
@@ -76,8 +76,8 @@
     "bind_to_port": true
    },
    {
-    "address": "tcp://0.0.0.0:443",
-    "name": "http_0.0.0.0_443",
+    "address": "tcp://[::]:443",
+    "name": "http_[::]_443",
     "filters": [
      {
       "type": "read",