Skip to content
This repository has been archived by the owner. It is now read-only.

Highlighted phrases not visible when searching #20

Closed
moskal91 opened this issue Oct 7, 2017 · 3 comments
Closed

Highlighted phrases not visible when searching #20

moskal91 opened this issue Oct 7, 2017 · 3 comments
Assignees
Labels
bug
Milestone

Comments

@moskal91
Copy link

@moskal91 moskal91 commented Oct 7, 2017

Using Kary Dark and Kary Minimal Dark theme, search results are barely visible:
image

Using default Dark+ theme, the same scenario looks like this:
image

It is hard to find search results in long lines of code because of this issue.

@pmkary

This comment has been minimized.

Copy link
Owner

@pmkary pmkary commented Oct 7, 2017

Yeah you're right... Thanks a lot for this issue, I'll fix it in the next version.

@pmkary pmkary added the bug label Oct 7, 2017
@pmkary pmkary self-assigned this Oct 7, 2017
@pmkary

This comment has been minimized.

Copy link
Owner

@pmkary pmkary commented Oct 23, 2017

So many improvements regarding of highlights happened. I really hope you like it. This is a preview before the actual version so hint me if you don't like it:

Search Highlights

screen shot 2017-10-22 at 6 13 37 pm

screen shot 2017-10-22 at 6 17 18 pm

Word Highlights

screen shot 2017-10-23 at 3 05 35 pm

screen shot 2017-10-23 at 12 05 11 am

@moskal91

This comment has been minimized.

Copy link
Author

@moskal91 moskal91 commented Oct 25, 2017

Looks very nice and does the job for me, thanks for looking into it!

@pmkary pmkary closed this Oct 25, 2017
@pmkary pmkary added this to the 16.0.0 milestone Oct 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.