How to contribute

Francesco Guardiani edited this page Aug 23, 2017 · 2 revisions

How to contribute to slush-vertx

If you are searching for technical info on how to contribute:

Logging Issues

Log an issue for any problem you might have. When in doubt, log an issue, any additional policies about what to include will be provided in the responses.

For questions that are not an issue with the code, e.g.: questions related to usage of the project, it is recommended that they are sent to the community group. This exposes the question to the whole community, which increases the chance of getting faster responses than just from contributors and committers.

Contributions

Any change that would roughly be more than 10 lines (non-trivial change) to resources in this repository must be through pull requests. This applies to all changes to documentation, code, binary files, etc. Even long term committers must use pull requests. Changes less than 10 lines or so (e.g.: correcting typos, small changes to configuration and such-like) can be make directly on a master branch.

No pull request can be merged without being reviewed.

For non-trivial contributions, pull requests should sit for at least 36 hours to ensure that contributors in other time zones have time to review. Consideration should also be given to weekends and other holiday periods to ensure active committers all have reasonable time to become involved in the discussion and review process if they wish.

The default for each contribution is that it is accepted once no committer has an objection. During review committers may also request that a specific contributor who is most versed in a particular area gives a "LGTM" before the PR can be merged.

In the case of an objection being raised in a pull request by another committer, all involved committers should seek to arrive at a consensus by way of addressing concerns being expressed by discussion, compromise on the proposed change, or withdrawal of the proposed change.

Becoming a Contributor

Becoming a contributor to the project should be an easy step. In order to reduce that barrier new contributors should look for issues tagged as:

  • Quick Win
  • Help Wanted

These tags should be applied to issues that are relatively simple to fix but not critical to be handled by the current group of committers. Once you pick such an issue to work on a discussion with a committer should happen on the issue itself and the committer should guide you with the mentoring/onboarding process.

Becoming a Committer

All contributors who land a non-trivial contribution should be on-boarded in a timely manner, and added as a committer, and be given write access to the repository.

Committers are expected to follow this policy and continue to send pull requests, go through proper review, and have other committers merge their pull requests.

You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.
Press h to open a hovercard with more details.