New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/makeserver not making correct PocketMine-MP.phar #29

Closed
JackMD opened this Issue Apr 13, 2018 · 12 comments

Comments

Projects
None yet
2 participants
@JackMD

JackMD commented Apr 13, 2018

Description

Whenever I try to make PocketMine-MP.phar using DevTools it outputs a PocketMine-MP.phar file which is only of 329 bytes.

Steps to Reproduce

  • Install Devtools build #91
  • Try doing /makeserver,
  • The PocketMine-MP.phar generated would have a size of 329 bytes.

OS and versions

  • PocketMine-MP: #935
  • PHP: 7.2.4
  • Server OS: Windows
  • Game version: PE/Win10
@dktapps

This comment has been minimized.

Member

dktapps commented Apr 13, 2018

If you're using a Jenkins phar you won't be able to create a phar with /makeserver anyway, nor do I know why you would want to.

@JackMD

This comment has been minimized.

JackMD commented Apr 13, 2018

I am not using Jenkins phar I was trying to create the .phar using the src via /makeserver

@dktapps

This comment has been minimized.

Member

dktapps commented Apr 13, 2018

PocketMine-MP: #935

excuse me?

@JackMD

This comment has been minimized.

JackMD commented Apr 13, 2018

Well I meant the src re;lated to that. As that was the latest build number.

@JackMD

This comment has been minimized.

JackMD commented Apr 13, 2018

This .phar file was generated by DevTools.

@dktapps

This comment has been minimized.

Member

dktapps commented Apr 13, 2018

I can't reproduce this on Linux, at least. This may be Windows specific. Could you copy the output of /makeserver?

@JackMD

This comment has been minimized.

JackMD commented Apr 13, 2018

[19:01:43] [Server thread/INFO]: [DevTools] Adding files...
[19:01:44] [Server thread/INFO]: [DevTools] Added 0 files
[19:01:44] [Server thread/INFO]: [DevTools] Checking for compressible files...
[19:01:44] [Server thread/INFO]: [DevTools] Done in 0.61s
[19:01:44] [Server thread/INFO]: PocketMine-MP 1.7dev Phar file has been created on F:\PM-MP\plugins\DevTools/\Pocke
tMine-MP_1.7dev.phar
@JackMD

This comment has been minimized.

JackMD commented Apr 13, 2018

Also if the PocketMine.phar is already present in the DevTools folder following error occurs

[19:01:32] [Server thread/INFO]: Phar file already exists, overwriting...
[19:01:32] [Server thread/INFO]: An unknown error occurred while attempting to perform this command
[19:01:32] [Server thread/CRITICAL]: Unhandled exception executing command 'makeserver' in makeserver: Unknown phar
archive "F:\PM-MP\plugins\DevTools/\PocketMine-MP_1.7dev.phar": in phar "F:\PM-MP\plugins\DevTools\PocketMine-MP_1.7
dev.phar", manifest claims to have zero entries.  Phars must have at least 1 entry
[19:01:32] [Server thread/CRITICAL]: PharException: "Unknown phar archive "F:\PM-MP\plugins\DevTools/\PocketMine-MP_
1.7dev.phar": in phar "F:\PM-MP\plugins\DevTools\PocketMine-MP_1.7dev.phar", manifest claims to have zero entries. P
hars must have at least 1 entry" (EXCEPTION) in "plugins/DevTools.phar/src/DevTools/DevTools" at line 251
[19:01:32] [Server thread/DEBUG]: #0 plugins/DevTools.phar/src/DevTools/DevTools(251): Phar::unlinkArchive(string F:
\PM-MP\plugins\DevTools/\PocketMine-MP_1.7dev.phar)
[19:01:32] [Server thread/DEBUG]: #1 plugins/DevTools.phar/src/DevTools/DevTools(237): DevTools\DevTools->buildPhar(
pocketmine\command\ConsoleCommandSender object, string F:\PM-MP\plugins\DevTools/\PocketMine-MP_1.7dev.phar, string
F:/PM-MP/, array Array(), array Array(), string <?php require_once("phar://". __FILE__ ."/src/pocketmine/PocketMine.
php");  __HALT_COMPILER();, integer 2)
[19:01:32] [Server thread/DEBUG]: #2 plugins/DevTools.phar/src/DevTools/DevTools(87): DevTools\DevTools->makeServerC
ommand(pocketmine\command\ConsoleCommandSender object, pocketmine\command\PluginCommand object, string makeserver, a
rray Array())
[19:01:32] [Server thread/DEBUG]: #3 src/pocketmine/command/PluginCommand(58): DevTools\DevTools->onCommand(pocketmi
ne\command\ConsoleCommandSender object, pocketmine\command\PluginCommand object, string makeserver, array Array())
[19:01:32] [Server thread/DEBUG]: #4 src/pocketmine/command/SimpleCommandMap(258): pocketmine\command\PluginCommand-
>execute(pocketmine\command\ConsoleCommandSender object, string makeserver, array Array())
[19:01:32] [Server thread/DEBUG]: #5 src/pocketmine/Server(1946): pocketmine\command\SimpleCommandMap->dispatch(pock
etmine\command\ConsoleCommandSender object, string makeserver)
[19:01:32] [Server thread/DEBUG]: #6 src/pocketmine/Server(1931): pocketmine\Server->dispatchCommand(pocketmine\comm
and\ConsoleCommandSender object, string makeserver)
[19:01:32] [Server thread/DEBUG]: #7 src/pocketmine/Server(2492): pocketmine\Server->checkConsole()
[19:01:32] [Server thread/DEBUG]: #8 src/pocketmine/Server(2243): pocketmine\Server->tick()
[19:01:32] [Server thread/DEBUG]: #9 src/pocketmine/Server(2119): pocketmine\Server->tickProcessor()
[19:01:32] [Server thread/DEBUG]: #10 src/pocketmine/Server(1701): pocketmine\Server->start()
[19:01:32] [Server thread/DEBUG]: #11 src/pocketmine/PocketMine(305): pocketmine\Server->__construct(BaseClassLoader
 object, pocketmine\utils\MainLogger object, string F:\PM-MP\, string F:\PM-MP\plugins\)
@JackMD

This comment has been minimized.

JackMD commented Apr 13, 2018

And to be exact I am using the src after this commit. a30a157

@dktapps

This comment has been minimized.

Member

dktapps commented Apr 13, 2018

I doubt the PM version has anything to do with it.

@JackMD

This comment has been minimized.

JackMD commented Apr 13, 2018

I can also tell that everything worked well using this DevTools build until I updated to the development build of PocketMine-MP. After then this error started to occur. So I updated to latest build of DevTools acquired from poggit.

@dktapps

This comment has been minimized.

Member

dktapps commented Apr 13, 2018

it seems to be Windows-specific... reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment