Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grass can replace itself when placed by players #2813

Open
Johnmacrocraft opened this Issue Mar 12, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@Johnmacrocraft
Copy link
Contributor

commented Mar 12, 2019

Issue description

Players can replace grass (this also includes tallgrass) with any of grasses. This does not happen in vanilla.

Steps to reproduce the issue

  1. Place any type of grass
  2. Try to place any of the grasses again (the same type works too, but the other one is recommended for an easier look) in the same position
  3. Notice that you hear the sound of placing and the grass being replaced

OS and versions

Tested on PocketMine-MP master branch server

  • Game version: PE/Win10 (delete as appropriate)

Plugins

Once again, tested on PocketMine-MP master branch server

  • If you remove all plugins, does the issue still occur?
  • If the issue is not reproducible without plugins:
    • Have you asked for help on our forums before creating an issue?
    • Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section

Crashdump, backtrace or other files

@jasonwynn10

This comment has been minimized.

Copy link
Contributor

commented Mar 12, 2019

Dead bushes should also not be able to replace grass

@dktapps

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

I doubt that's intentional behaviour. Dead bush is non-replaceable, and non-replaceable pretty much always takes precedence over replaceable from what I've seen.

I'd recommend testing in PC 1.13 and not MCPE. (this doesn't imply that I've tested this myself, but as a side note.)

@dktapps

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

re to the bush issue: In PC 1.14 snapshots they are not placeable on grass blocks, but can replace tallgrass.

@dktapps dktapps added this to the 4.0 milestone Mar 13, 2019

@dktapps

This comment has been minimized.

Copy link
Member

commented Mar 13, 2019

As far as I can tell, the behaviour is that any replaceable block can be replaced by anything except itself. This is a little difficult to implement in PM due to how block placement currently works. It will necessitate block transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.