Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlockDecayEvent instead LeavesDecayEvent #3578

Closed
AkmalFairuz opened this issue Jun 11, 2020 · 5 comments
Closed

Add BlockDecayEvent instead LeavesDecayEvent #3578

AkmalFairuz opened this issue Jun 11, 2020 · 5 comments
Labels
Category: API Related to the plugin API Type: Change Proposal RFCs (Request for Comments) on change ideas for PocketMine-MP

Comments

@AkmalFairuz
Copy link
Contributor

AkmalFairuz commented Jun 11, 2020

Description

Add event to handle block decay event include Flowing Water and Flowing Lava decay.

Justification

We cannot handle flowing water or lava when decay, only Leaves can handle

Alternative methods

Register new Water Block then put custom event when setBlock into air

@dktapps
Copy link
Member

dktapps commented Jun 11, 2020

Lava and water don't decay. Lumping this behaviour in with Leaves decay would be wrong and misleading.

@AkmalFairuz
Copy link
Contributor Author

I mean Flowing Water and Lava

@dktapps
Copy link
Member

dktapps commented Jun 11, 2020

I know what you mean. My point stands.

@AkmalFairuz
Copy link
Contributor Author

So , May I create pull request about this issue?

@dktapps
Copy link
Member

dktapps commented Jun 22, 2020

Asking if you can create a pull request kind of defeats the object of making a pull request...

@dktapps dktapps added Category: API Related to the plugin API Type: Change Proposal RFCs (Request for Comments) on change ideas for PocketMine-MP labels Jun 22, 2020
@SOF3 SOF3 closed this as completed Mar 27, 2021
@pmmp pmmp locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: API Related to the plugin API Type: Change Proposal RFCs (Request for Comments) on change ideas for PocketMine-MP
Projects
None yet
Development

No branches or pull requests

3 participants