New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StructureBlockUpdatePacket: Added encode/decode #3148
Conversation
TODO: Find constants for StructureBlockType
src/pocketmine/network/mcpe/protocol/StructureBlockUpdatePacket.php
Outdated
Show resolved
Hide resolved
It would be nice if someone could peer-review this and confirm the changes. |
I have no acquaintances who could confirm this. Usually I check that others write about the protocol, and for this reason they often started contacting me for advice. :^/ |
I don’t know if you are interested or not, but I found similar information about this packet from Sandertv. Maybe ask him to confirm or deny this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had a look over it and it looks good. We had a talk about it on Discord.
This should have been targeted at This also needs to be rechecked against Minecraft 1.14 to ensure that it's still in line with latest changes. |
Okay, I rechecked the read/write methods of StructureBlockUpdatePacket in BDS 1.14.30.2 and made sure that nothing has changed there. I also rechecked serialize/unserialize methods of StructureEditorData and StructureSettings - there are no changes either. |
Introduction
Added encode decode for StructureBlockUpdatePacket, which can be used for StructureBlockActor!
The player sends it to the server when changing the settings of StructureBlockActor.
Changes
API changes
Without API changes
Behavioural changes
Without behavioural changes
Tests
I don’t think that he is really needed here. However, I will try later to add StructureBlockActor and using the packets I will test it myself.