Remove unnecessary Cancellable implementation#5359
Merged
dktapps merged 1 commit intopmmp:stablefrom Nov 23, 2022
Merged
Conversation
Contributor
Author
|
Cancellable is already implemented in BaseBlockChangeEvent |
Member
|
Does it really make sense to implement Cancellable on BaseBlockChangeEvent generically? |
Member
|
I don't see why not, but it can't be changed before PM5 anyway. |
jasonw4331
added
Category: API
Contributor
Author
|
Why did you add the label "Waiting on Author"? |
dktapps
added
Type: Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Remove unnecessary Cancellable implementation
Relevant issues
Changes
API changes
Behavioural changes
Backwards compatibility
Follow-up
Tests