Fix missing sounds when interacting with item frames#5383
Merged
dktapps merged 6 commits intopmmp:next-minorfrom Nov 25, 2022
Merged
Conversation
JavierLeon9966
suggested changes
Nov 2, 2022
dktapps
reviewed
Nov 7, 2022
Member
|
Retargeting this to next-minor since it's adding new APIs. |
jasonw4331
added
Category: Gameplay
this should be handled by useBreakOn(), and missing destroy sounds like this are part of a larger bug.
Member
|
I've removed the onNearbyBlockChange changes since those don't directly pertain to interaction, and the missing sounds there are part of a larger issue which should be solved in a more generic way. The rest of the PR is good to merge though. |
dktapps
added
Type: Enhancement
zSALLAZAR
deleted the
fix-missing-sounds-when-interacting-with-item-frames
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Relevant issues
#5168
Changes
API changes
Behavioural changes
Backwards compatibility
Follow-up
Tests
Minecraft.2022-11-02.21-24-49.-.Trim.-.Trim.mp4