BaseInventory: Validate given array to make sure correct items are given.#5391
Merged
dktapps merged 1 commit intopmmp:stablefrom Nov 7, 2022
alvin0319:fix/set-contents
Merged
BaseInventory: Validate given array to make sure correct items are given.#5391dktapps merged 1 commit intopmmp:stablefrom alvin0319:fix/set-contents
dktapps merged 1 commit intopmmp:stablefrom
alvin0319:fix/set-contents
Conversation
alvin0319
changed the title
Member
|
For posterity: Validation of array types this way is only necessary if the method in question is exposed to plugins. Internal-use stuff doesn't require validation since PHPStan will take care of it (and runtime validation hurts performance). |
dktapps
added
Type: Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
BaseInventory::setContents()does not validate the given array, so when the server crashes due to an invalid array given, developers may hard to find what went wrong.Relevant issues
N/A
Changes
API changes
Behavioural changes
Backwards compatibility
Follow-up
Tests