refactor: react-merge-refs => useImperativeHandle #1009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'm not going to be able to unravel the typing woes around Instances etc. Leaving this as a draft for now. |
|
never thought of that, nice trick actually :-O |
|
if you want just do any and let someone else figure it out, there are places where i did that bc it just blocked everything. useImperativeHandle makes so much sense here instead of react-use-refs, and rur has even caused problems in the past because their later version breaks compat, so removing that would be awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What
Removes
react-merge-refsin favor of React's built-inuseImperativeHandle.Checklist