Skip to content

feat: jotai/rxjs #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jul 15, 2021
Merged

feat: jotai/rxjs #341

merged 25 commits into from
Jul 15, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Mar 6, 2021

from: #234 (comment)

  • read-only atomWithObservable
  • writable atomWithObservable
  • tests
  • examples (help wanted)
  • docs (help wanted)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a45dd42:

Sandbox Source
React Configuration
React Typescript Configuration

@dai-shi
Copy link
Member Author

dai-shi commented Mar 6, 2021

https://codesandbox.io/s/react-typescript-forked-f5hw7?file=/src/App.tsx
Here's the minimal example.

@nibtime Can you experiment with this?

@nibtime
Copy link

nibtime commented Mar 6, 2021

@dai-shi wow that went fast! Sure, if there's already a setup I prefer that.

what's your preferred way of feedback once I got something going?

@dai-shi
Copy link
Member Author

dai-shi commented Mar 6, 2021

@nibtime Would you join pmndrs discord server and also DM me? https://discord.gg/poimandres

@dai-shi dai-shi mentioned this pull request Apr 1, 2021
49 tasks
@vercel
Copy link

vercel bot commented Apr 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/4Foff48oU5qh1pEpcnapPeMsgBQD
✅ Preview: https://jotai-git-feat-rxjs-pmndrs.vercel.app

@dai-shi
Copy link
Member Author

dai-shi commented Apr 13, 2021

Would anyone else be interested in working on this?

@Thisen Thisen self-assigned this May 31, 2021
@Thisen
Copy link
Collaborator

Thisen commented May 31, 2021

@dai-shi I've assigned myself.

@dai-shi
Copy link
Member Author

dai-shi commented Jun 26, 2021

This need to be re-implemented.

@dai-shi dai-shi changed the title wip: jotai/rxjs feat: jotai/rxjs Jul 14, 2021
@dai-shi dai-shi marked this pull request as ready for review July 14, 2021 02:03
@dai-shi
Copy link
Member Author

dai-shi commented Jul 14, 2021

I feel like we should ship this as an experimental feature and look for contributors.

@dai-shi dai-shi requested a review from Thisen July 14, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants